Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): make locationSyncBootstrapListener public due to change … #22896

Closed
wants to merge 2 commits into from
Closed

fix(router): make locationSyncBootstrapListener public due to change … #22896

wants to merge 2 commits into from

Conversation

jasonaden
Copy link
Contributor

…in output after TS 2.7 update in #22669

See build diff on 2.7 here:

angular/router-builds@8788b39#diff-068e657ab436c99f423c5ad8d4187c1b

IgorMinar
IgorMinar suggested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you type the useFactory prop as (ngUpgrade: UpgradeModule) => () => void by casting the initializer value?

we shouldn't export random private stuff just to make the compiler happy.

@mary-poppins
Copy link

You can preview de94b19 at https://pr22896-de94b19.ngbuilds.io/.

@jasonaden
Copy link
Contributor Author

@IgorMinar Sounds good. Updated.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 20, 2018
@ngbot
Copy link

ngbot bot commented Mar 20, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    pending status "ci/circleci: build" is pending
    pending status "google3" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar
Copy link
Contributor

@jasonaden please reformat

@mary-poppins
Copy link

You can preview 37a5d18 at https://pr22896-37a5d18.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 86e68b1 at https://pr22896-86e68b1.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 623d769 Mar 21, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@jasonaden @leo6104
fix(router): make locationSyncBootstrapListener public due to change …
23bc4d1 
…in output after TS 2.7 update in angular#22669 (angular#22896)

PR Close angular#22896
jmleoni pushed a commit to jmleoni/angular that referenced this pull request Oct 6, 2018
@jasonaden @IgorMinar
fix(router): make locationSyncBootstrapListener public due to change …
89e6faa 
…in output after TS 2.7 update in angular#22669 (angular#22896)

PR Close angular#22896
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasonaden @mary-poppins @IgorMinar @googlebot